Skip to content

revert: Remove CSS that hides the signatures on custom certificates - #462

Merged
lcamacho merged 1 commit into
opencraft-release/koa.3-asu-ytpfrom
lcamacho/BB-5336
Mar 2, 2022
Merged

revert: Remove CSS that hides the signatures on custom certificates#462
lcamacho merged 1 commit into
opencraft-release/koa.3-asu-ytpfrom
lcamacho/BB-5336

Conversation

@lcamacho

@lcamacho lcamacho commented Mar 1, 2022

Copy link
Copy Markdown

Description

This reverts "Remove CSS that hides the signatures on custom certificates"

Testing Instructions

  1. Checkout this branch
  2. Install the ASU-YTP theme
  3. Setup the certificate
  4. Check the certificate, and see the signature is shown since theme is overwriting this

@lcamacho
lcamacho requested a review from farhaanbukhsh March 1, 2022 21:00

@farhaanbukhsh farhaanbukhsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be moved to the theme repository right, I don't see a corresponding PR for the theme :) can you have a look at this, please :)

Got it 🥇 Makes sense :)

@farhaanbukhsh farhaanbukhsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this on the local devstack
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@lcamacho
lcamacho merged commit 81ce879 into opencraft-release/koa.3-asu-ytp Mar 2, 2022
@lcamacho
lcamacho deleted the lcamacho/BB-5336 branch March 2, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants