Skip to content

feat: add PREPEND_LOCALE_PATHS configuration setting (#29851) - #460

Merged
keithgg merged 1 commit into
opencraft-release/lilac.2from
keith/se_5299_lilac
Feb 18, 2022
Merged

feat: add PREPEND_LOCALE_PATHS configuration setting (#29851)#460
keithgg merged 1 commit into
opencraft-release/lilac.2from
keith/se_5299_lilac

Conversation

@keithgg

@keithgg keithgg commented Feb 14, 2022

Copy link
Copy Markdown

edx-platform supports COMPREHENSIVE_THEME_LOCALE_PATHS setting, which
appends paths to the end of LOCALE_PATHS, but there's currently no
way to add additional paths to the start of the list.

https://tasks.opencraft.com/browse/SE-5299

Note. This is a cherry-picked commit from the merged PR: openedx#29851

edx-platform supports COMPREHENSIVE_THEME_LOCALE_PATHS setting, which
appends paths to the end of LOCALE_PATHS,  but there's currently no
way to add additional paths to the start of the list.

https://tasks.opencraft.com/browse/SE-5299
@mtyaka

mtyaka commented Feb 18, 2022

Copy link
Copy Markdown
Member

Looking good, let's merge this! 👍

  • I tested this: I tested the upstream PR, but not this cherry-pick specifically because the changes are simple and the commit applied cleanly.
  • I read through the code

@keithgg
keithgg merged commit 6c85162 into opencraft-release/lilac.2 Feb 18, 2022
@keithgg
keithgg deleted the keith/se_5299_lilac branch February 18, 2022 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants