Skip to content

Added day first date configuration to Schedule & Details settings page - #456

Closed
jbcurtin wants to merge 2 commits into
open-craft:opencraft-release/lilac.2-uqfrom
jbcurtin:day-first-date-configuration
Closed

Added day first date configuration to Schedule & Details settings page#456
jbcurtin wants to merge 2 commits into
open-craft:opencraft-release/lilac.2-uqfrom
jbcurtin:day-first-date-configuration

Conversation

@jbcurtin

@jbcurtin jbcurtin commented Jan 31, 2022

Copy link
Copy Markdown

Description goes here. e.g. This PR contains the LibraryContent XBlock, which allows to display library content in a course.

JIRA tickets: https://tasks.opencraft.com/browse/BB-5429

Testing instructions:

  1. Set branch to day-first-date-configuration
OPENEDX_RELEASE=day-first-date-configuration
  1. Open up page
  1. Notice the dates are set to mm/dd/yyyy format
  2. Edit cms/envs/common.py::FEATURES to include DAY_FIRST_DATE_CONFIGURATION
FEATURES = {
...
    DAY_FIRST_DATE_CONFIGURATION: True,
} 
  1. Wait for LMS to restart
  2. Go back to opened page
  1. Notice that the dates are now set with the day first, followed by month: dd/mm/yyyy

Author notes and concerns:
I'm not sure where the best place to expose this setting value in edx-platform. Would you like to suggest a location?

@jbcurtin jbcurtin closed this Feb 1, 2022
@jbcurtin jbcurtin reopened this Feb 2, 2022
@farhaanbukhsh
farhaanbukhsh changed the base branch from opencraft-release/lilac.2 to opencraft-release/lilac.2-uq February 4, 2022 10:30

@farhaanbukhsh farhaanbukhsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added some changes and pushed a feature branch to opencraft/edx-platform as jbcurtin/bb-5429-day-first-date-configuration, please change the source branch as well.

Comment thread cms/envs/common.py Outdated
Comment thread cms/djangoapps/contentstore/views/course.py Outdated
Comment thread cms/djangoapps/contentstore/views/course.py Outdated
@jbcurtin

jbcurtin commented Feb 4, 2022

Copy link
Copy Markdown
Author

Hi @farhaanbukhsh , I'm unable to update the feature branch. I've pushed an update to this pull request. The alterations are consistent with messaging so that the user isn't lost in what the feature might be about.

@farhaanbukhsh

Copy link
Copy Markdown
Member

Closing in favour of #459

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants