Pvgp/se4781/opencraft release/koa.3 esme - #422
Merged
pedrovgp merged 3 commits intoOct 1, 2021
Merged
Conversation
The customer required replacing the default list, which requires deleting these snippet files.
ADD html snippets from overview unit From here: https://studio.esme-staging.opencraft.hosting/course/course-v1:esme+CT+2021?show=block-v1%3Aesme%2BCT%2B2021%2Btype%40chapter%2Bblock%400d4aefe059784786bd1f8eb850a633b2 The snippets from the overview Unit were added. ADD snippets from all other subsections Added snippets from Typical Section and Quiz CSS lines were removed from all files, as per requested. CORRECT typo which made template invalid
jvdm
approved these changes
Oct 1, 2021
jvdm
left a comment
jvdm
left a comment
There was a problem hiding this comment.
👍
- I tested this: Tested across the previous change submitted to koa.3 branch.
- I read through the code
- N/A I checked for accessibility issues
- Includes documentation. Code comments are in place where resonable.
- N/A I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to push to ESME staging instances this PR here #405
Ticket: https://tasks.opencraft.com/browse/SE-4781