[FAL-2030] Updates kombu package to support multi-tenant redis authentication - #397
Merged
Merged
Conversation
Constrains kombu to https://github.com/open-craft/kombu/tree/v4.6.11.1 to allow us to use celery with multi-tenant redis. (cherry picked from commit 3bd3d1e)
which can be configured from the lms/studio environment (cherry picked from commit 3c1a43e)
pomegranited
force-pushed
the
jill/koa/redis-kombu-auth
branch
from
September 9, 2021 04:58
bb91c16 to
3019422
Compare
samuelallan72
approved these changes
Sep 10, 2021
samuelallan72
left a comment
samuelallan72
left a comment
Member
There was a problem hiding this comment.
- I tested this: followed test instructions
- I read through the code
- I checked for accessibility issues
- Includes documentation
- [NA] I made sure any change in configuration variables is reflected in the corresponding
client'sconfiguration-securerepository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports https://github.com/edx/edx-platform/pull/28020 to our koa.3 release branch.
Note that this code drift can be dropped once the celery constraint is dropped and celery is updated to
>=5.2.0, because it will pull in our upstream kombu changes which were released with kombu v5.2.0rc1.Note that here, I use the tag v4.6.11.1 instead of the branch name; will update the upstream PR to use this too.
Jira ticket
FAL-2030
Sandbox
Sandbox is provisioning:
Testing instructions
The extended heartbeat check for celery is sufficient to test that these changes don't disrupt functionality on the sandbox as configured below.