Skip to content

[BB-3954] Backport: Add toggle to redirect user to the login page on unauthenticated enrollement #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shimulch merged 2 commits into from
Aug 20, 2021
Merged

[BB-3954] Backport: Add toggle to redirect user to the login page on unauthenticated enrollement #389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38671c8
fix: redirect unauthenticated user to the login page on enroll
arjunsinghy96 Mar 31, 2021
ac18ef7
chore: remove toggle
Aug 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lms/envs/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,10 +702,6 @@
# e.g. COURSE_BLOCKS_API_EXTRA_FIELDS = [ ('course', 'other_course_settings'), ("problem", "weight") ]
COURSE_BLOCKS_API_EXTRA_FIELDS = []

# Setting to redirect unauthenticated users to the login page when enrolling from the course about
# page instead of showing an error message. After successful login redirects them back to the course about page.
REDIRECT_UNAUTHENTICATED_USER_TO_LOGIN_ON_ENROLL = False

# Settings for the course reviews tool template and identification key, set either to None to disable course reviews
COURSE_REVIEWS_TOOL_PROVIDER_FRAGMENT_NAME = 'coursetalk-reviews-fragment.html'
COURSE_REVIEWS_TOOL_PROVIDER_PLATFORM_KEY = 'edx'
Expand Down
9 changes: 2 additions & 7 deletions lms/templates/courseware/course_about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,13 +40,8 @@
location.href = xhr.responseText;
}
} else if (xhr.status == 403) {
%if settings.REDIRECT_UNAUTHENTICATED_USER_TO_LOGIN_ON_ENROLL:
location.replace("${reverse('signin_user') | n, js_escaped_string}?next=${request.path | u}");
%else:
$('#register_error').text(
(xhr.responseText ? xhr.responseText : "${_("An error has occurred. Please ensure that you are logged in to enroll.") | n, js_escaped_string}")
).css("display", "block");
%endif
// redirect unauthenticated user to the login page
location.replace("${reverse('signin_user') | n, js_escaped_string}?next=" + encodeURIComponent("${request.path | n, js_escaped_string}"));
} else {
$('#register_error').text(
(xhr.responseText ? xhr.responseText : "${_("An error occurred. Please try again later.") | n, js_escaped_string}")
Expand Down