Skip to content

fix: change buttons in wiki modal to anchor tags - #368

Merged
arjunsinghy96 merged 1 commit into
opencraft-release/koa.3from
arjun/bb-4360-wiki
Jun 28, 2021
Merged

fix: change buttons in wiki modal to anchor tags#368
arjunsinghy96 merged 1 commit into
opencraft-release/koa.3from
arjun/bb-4360-wiki

Conversation

@arjunsinghy96

Copy link
Copy Markdown

The action buttons in wiki modal have href attribute
but does not have an event listener for click.
This PR changes the buttons to anchor tags so that they
work as expected when clicked.

Related Tickets

Reproducing the buggy behavior

  1. Enroll in any Course
  2. Go to Wiki
  3. Create an article
  4. Make 2-3 edits and save after each edit
  5. Click on Changes
  6. Select any revision and click "Merge selected with current"
  7. Click "Create new merged version". Check that this does not trigger any action.

Testing Instructions

  1. Checkout to this branch.
  2. Go to Wiki
  3. Create an article
  4. Make 2-3 edits and save after each edit
  5. Click on Changes
  6. Select any revision and click "Merge selected with current"
  7. Click "Create new merged version".
  8. Verify that this triggers a merge request.
  9. Wait for request to succeed and page to reload.
  10. A new merged revision should be created.

Author Notes:

  1. Merge versions action was pretty slow on my local devstack. Please wait for some time for the merge version request to succeed.

The action buttons in wiki modal have href attribute
but does not have an event listener for click.
This PR changes the buttons to anchor tags so that they
work as expected when clicked.

@shimulch shimulch left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arjunsinghy96. Thanks for fixing this. LGTM 👍

  • I tested this in my local devstack. Reproduced the issue and verified that this PR fixes the issue.
  • I read through the code
  • [N/A] I checked for accessibility issues
  • [N/A] Includes documentation
  • [N/A] I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@arjunsinghy96
arjunsinghy96 merged commit 1f5d70f into opencraft-release/koa.3 Jun 28, 2021
dliberat pushed a commit that referenced this pull request Jul 8, 2021
fix: change buttons in wiki modal to anchor tags
@Agrendalath
Agrendalath deleted the arjun/bb-4360-wiki branch July 26, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants