Skip to content

[BB-4385] Prevent course details AJAX request from getting into browser history (backport) - #363

Merged
0x29a merged 1 commit into
opencraft-release/koa.3from
0x29a/bb4385/fix_moving_back_on_settings_page_backport
Jun 22, 2021
Merged

[BB-4385] Prevent course details AJAX request from getting into browser history (backport)#363
0x29a merged 1 commit into
opencraft-release/koa.3from
0x29a/bb4385/fix_moving_back_on_settings_page_backport

Conversation

@0x29a

@0x29a 0x29a commented Jun 18, 2021

Copy link
Copy Markdown

Backport of https://github.com/edx/edx-platform/pull/27979 to opencraft-release/koa.3.

Peek 2021-06-18 06-44

JIRA tickets:

Sandbox URL: TBD - sandbox is being provisioned.

Testing instructions:

  1. Using your local devstack, make the same action as shown on image from description and make sure that issue is resolved.

Reviewers

@0x29a
0x29a requested a review from shimulch June 18, 2021 04:06
@shimulch

Copy link
Copy Markdown

@0x29a I've tried to generate the issue in both local devstack and stage.nelp.gov.sa. But I've failed to generate it in both places. Could you give me more info on the issue?

@0x29a

0x29a commented Jun 22, 2021

Copy link
Copy Markdown
Author

@shimulch, that's strange. I just asked in chat and @arjunsinghy96 could reproduce it. Detailed steps are:

  1. Go to http://localhost:18010/settings/details/course-v1:edX+DemoX+Demo_Course
  2. Wait for last request on page to http://localhost:18010/settings/details/course-v1:edX+DemoX+Demo_Course URL, with application/json content type.
  3. Then click on the logo image in the top-left corner and wait for the page to completely load.
  4. Go back one page. You should see raw JSON instead of platform page.

@shimulch shimulch left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0x29a Thanks for the detailed instruction. I was going back to the studio home before that ajax request getting completed.

LGTM 👍🏽

  • I tested this: in my local devstack I've reproduced this issue and tested this PR fixes that.
  • I read through the code
  • [N/A] I checked for accessibility issues
  • Includes documentation
  • [N/A] I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@0x29a
0x29a merged commit 0df896d into opencraft-release/koa.3 Jun 22, 2021
@0x29a
0x29a deleted the 0x29a/bb4385/fix_moving_back_on_settings_page_backport branch June 22, 2021 16:49
dliberat pushed a commit that referenced this pull request Jul 8, 2021
…on_settings_page_backport

[BB-4385] Prevent course details AJAX request from getting into browser history (backport)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants