Skip to content

[BB-4218] Update Arabic translations (Juniper) - #357

Merged
giovannicimolin merged 1 commit into
opencraft-release/juniper.3from
shimulch/bb-4218
Jun 4, 2021
Merged

[BB-4218] Update Arabic translations (Juniper)#357
giovannicimolin merged 1 commit into
opencraft-release/juniper.3from
shimulch/bb-4218

Conversation

@shimulch

@shimulch shimulch commented Jun 3, 2021

Copy link
Copy Markdown

Description

This PR adds the latest reviewed Arabic translation from Transifex for opencraft-release/juniper.3.

Supporting information

Testing instructions

  • Pull this PR in your local devstack
  • Open LMS shell - make lms-shell
  • Make Arabic default language by editing /edx/etc/lms.yml, set LANGUAGE_CODE: ar
  • Check if updated strings working

Deadline

None

Other information

Reviewer

@shimulch shimulch changed the title [BB-4218] Update Arabic translations [BB-4218] Update Arabic translations (Juniper) Jun 3, 2021

@giovannicimolin giovannicimolin left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • I tested this:
  1. Checked this branch out in the devstack.
  2. Set the LMS language to ar.
  3. Checked that some of the newer strings were working.
  • I read through the code
  • I checked for accessibility issues NA
  • Includes documentation NA

@shimulch Good to go.

@giovannicimolin
giovannicimolin merged commit 7f5a557 into opencraft-release/juniper.3 Jun 4, 2021
@giovannicimolin
giovannicimolin deleted the shimulch/bb-4218 branch June 4, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants