[SE-4305] Reordering tabs not working in Koa - #337
Merged
Conversation
Arti3DPlayer
marked this pull request as ready for review
April 2, 2021 14:13
pkulkark
reviewed
Apr 5, 2021
pkulkark
reviewed
Apr 5, 2021
pkulkark
approved these changes
Apr 8, 2021
pkulkark
left a comment
Member
There was a problem hiding this comment.
@Arti3DPlayer LGTM 👍
- I tested this: Verified the pages positions can be moved as described in testing instructions
- I read through the code
-
I checked for accessibilityN/A -
Includes documentationN/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I removed static tabs priority, to make this reordering function works correctly
While we had default
priorityattribute set forProgressTabCoursewareTabget_course_tab_list() returned incorrect order.
Issue is starting from this line where we get all dynamic tabs:
course_tab_list += _get_dynamic_tabs(course, user)we are getting correct order.For example:
[[10, 'Course'], [inf, 'New Page'], [inf, 'Test'], [inf, 'Discussion'], [inf, 'Wiki'], [40, 'Progress'], [inf, 'Instructor']]But after doing sorting next time(for correctly sort static tabs as wee see in comment here), we receive this:
[[10, 'Course'], [40, 'Progress'], [inf, 'New Page'], [inf, 'Test'], [inf, 'Discussion'], [inf, 'Wiki'], [inf, 'Instructor']]Supporting information
Jira Issue: SE-4305
Testing instructions
/tabs/course-v1:edX+DemoX+Demo_Course)More information here Reordering pages
/courses/course-v1:edX+DemoX+Demo_Course/course/)Deadline
ASAP
Other information