Skip to content

Updates tpa email association waffle switch to support edx-toggles=1.1.1 - #318

Merged
0x29a merged 1 commit into
opencraft-release/koa.1from
nizar/se-3816-koa-fix
Feb 11, 2021
Merged

Updates tpa email association waffle switch to support edx-toggles=1.1.1#318
0x29a merged 1 commit into
opencraft-release/koa.1from
nizar/se-3816-koa-fix

Conversation

@nizarmah

@nizarmah nizarmah commented Feb 9, 2021

Copy link
Copy Markdown

Description

This change updates the third_party_auth.always_associate_user_by_email waffle switch's definition because Koa uses edx-toggles=1.1.1, instead of 2.0.0>edx-toggles>=1.2.0.

Supporting information

  • Jira Tickets: SE-3816, BB-3518

Testing instructions

Deadline

As soon as possible

@nizarmah
nizarmah requested a review from 0x29a February 9, 2021 08:55
This change updates the `third_party_auth.always_associate_user_by_email` waffle switch's definition because Koa uses `edx-toggles=1.1.1`, instead of `2.0.0>edx-toggles>=1.2.0`.
@nizarmah
nizarmah force-pushed the nizar/se-3816-koa-fix branch from 138aea8 to a34c917 Compare February 9, 2021 08:59

@0x29a 0x29a left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Thanks for the ready sandbox and top-notch test instructions, @nizarmah.

  • I tested this using test instructions from the linked PR.
  • I read through the code

@0x29a
0x29a merged commit c9bf9bf into opencraft-release/koa.1 Feb 11, 2021
@0x29a
0x29a deleted the nizar/se-3816-koa-fix branch February 11, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants