Allow course home behavior configuration to override unified course tab - #308
Merged
kaizoku merged 1 commit intoJan 7, 2021
Conversation
… unified course tab
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR amends a previous change (fe95b2b), which allows for configuring where the root URL of a course redirects to.
This older commit ignores the added configuration value if the unified course tab is set, but this removes the option to set the course root redirection when the unified course tab is enabled.
Here we move the check for the
COURSE_HOME_BEHAVIOURoption from the SiteConfiguration to before checking the unified course tab to allow us to still configure this when the unified course tab is enabled.JIRA tickets: Implements BB-3399
Discussions: Discussed on JIRA
Dependencies: None
Merge deadline: ASAP
Testing instructions:
course_experience.unified_course_tabflag to true in your devstack WaffleFlag settings"COURSE_HOME_BEHAVIOUR":"courseware",Reviewers