Skip to content

[SE-3440] Adds grade cutoffs to gradebook grading information - #305

Merged
nizarmah merged 1 commit into
opencraft-release/juniper.3from
nizar/adds-grade-cutoffs-to-grading-info-backport
Jan 6, 2021
Merged

[SE-3440] Adds grade cutoffs to gradebook grading information#305
nizarmah merged 1 commit into
opencraft-release/juniper.3from
nizar/adds-grade-cutoffs-to-grading-info-backport

Conversation

@nizarmah

@nizarmah nizarmah commented Jan 5, 2021

Copy link
Copy Markdown

Adds course grade_cutoffs to the /api/grades/v1/gradebook/{course_id}/grading-info.

JIRA tickets: SE-3440

Upstream Pull Request: https://github.com/edx/edx-platform/pull/25978

Sandbox URL:

Testing instructions:

Run the following function and verify that grade_cutoffs is highlighted 😃

curl --request POST \
  --insecure --url https://pr305.sandbox.stage.opencraft.hosting/oauth2/access_token/ \
  --header 'content-type: multipart/form-data;' \
  --form grant_type=client_credentials \
  --form client_id=LgIomajnBojAT0l65g0jFWxiJTODMejydpoDQDPR \
  --form client_secret=qO7Ng8OcwB4tQFbXilDdKIR2uADwfEJNGanSVaDieoq4n39XTExuEpN1qV4yCPiKpyFjKT7y1Awwsy17aCCNNtPl7F8YPYeu0oHV7WtHWOyZCKQ01Bj7POe2QDiZWZeF \
  | awk '{print substr($9, 2, length($9)-3)}' \
  | xargs -I "TOKEN" sh -c \
    "curl --request GET \
          --insecure --url 'https://pr305.sandbox.stage.opencraft.hosting/api/grades/v1/gradebook/course-v1:edX+DemoX+Demo_Course/grading-info' \
          --header 'authorization: Bearer TOKEN'" \
  | grep "grade_cutoff"

You can also update the grading scale for the Demo course, and verify those changes are reflected.

Author notes and concerns:

  1. If you'd prefer that I add a separate API endpoint for this, please let me know 👍🏼
  2. I know I shouldn't be sharing credentials, but this is a sandbox 🤷🏼‍♂️

Reviewers

@nizarmah
nizarmah requested a review from s0b0lev January 5, 2021 11:50
@nizarmah
nizarmah marked this pull request as ready for review January 5, 2021 11:50
@s0b0lev

s0b0lev commented Jan 5, 2021

Copy link
Copy Markdown

@nizarmah 👍 looks good

  • I tested this: call API, change the grading scale - changes were reflected
  • I read through the code

@nizarmah
nizarmah merged commit 3c5bda5 into opencraft-release/juniper.3 Jan 6, 2021
@nizarmah
nizarmah deleted the nizar/adds-grade-cutoffs-to-grading-info-backport branch January 6, 2021 02:28
nizarmah added a commit that referenced this pull request Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants