Skip to content

SE-3690 Update the Open edX logo urls (backport to opencraft-release/juniper.3) - #299

Merged
samuelallan72 merged 1 commit into
opencraft-release/juniper.3from
samuel/new-openedx-logo-urls
Dec 19, 2020
Merged

SE-3690 Update the Open edX logo urls (backport to opencraft-release/juniper.3)#299
samuelallan72 merged 1 commit into
opencraft-release/juniper.3from
samuel/new-openedx-logo-urls

Conversation

@samuelallan72

@samuelallan72 samuelallan72 commented Dec 17, 2020

Copy link
Copy Markdown
Member

Cherry picked from https://github.com/edx/edx-platform/pull/25898

Test instructions:

  • verify that this cleanly backports the referenced pull request
  • check an instance or your devstack with this branch, and verify that the new logos are displayed

Author notes:

  • This also updates the http open.edx.org links to https, matching upstream. Did this because there was a merge conflict on those lines, and updating to https made sense.

Reviewers:

The old URLs now serve the new logo, but at the old pixel size.  These
URLs serve the new logo at a natural pixel size.

(cherry picked from commit 3abd0e8)

@mavidser mavidser left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @swalladge - Good to merge 👍

  • I tested this: Checked that the logos are updated
  • I read through the code

@samuelallan72
samuelallan72 merged commit 370ffc4 into opencraft-release/juniper.3 Dec 19, 2020
@samuelallan72
samuelallan72 deleted the samuel/new-openedx-logo-urls branch December 19, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants