Switch grading data format in CourseEnrollmentSerializer - #298
Merged
kaizoku merged 1 commit intoDec 18, 2020
Merged
Conversation
0x29a
approved these changes
Dec 15, 2020
0x29a
left a comment
0x29a
left a comment
There was a problem hiding this comment.
👍
- I didn't manage to test this because I have no ironwood devstack and setting up working fork locally will take too much time for such trivial change.
- I read through the code
-
I checked for accessibility issues -
Includes documentation
kaizoku
changed the base branch from
opencraft-release/ironwood.2-asu-ytp
to
opencraft-release/ironwood.2
December 15, 2020 15:10
kaizoku
force-pushed
the
BB-3440-enrollment-grading-data-format
branch
from
December 15, 2020 15:15
233a441 to
def1cd2
Compare
Author
|
Thanks @0x29a. I switched this to our common Ironwood branch since I found this customization is also a part of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the format of the grading key from the CourseEnrollmentSerializer to remove the unnecessary wrapping in a list since it will always be a single item.
JIRA tickets: BB-3440
Merge deadline: Promptly
Testing instructions:
Check the format of the grading key under the course enrollments API and ensure it's not a list: http://localhost:18000/api/enrollment/v1/enrollment?user=honor
Author notes and concerns:
Reviewers