[SE-3745]: Cherry picks 2020-12-03 XSS security fixes from upstream - #297
Conversation
|
@eLRuLL, can you cherry-pick the single squashed commit containing the backported changes to the |
|
@eLRuLL here's the commit hash that you'll need to cherry-pick |
|
@eLRuLL you mentioned me as a reviewer for this PR. I have followed the testing checklist - instance pr297 works as expected. It looks like commits were squashed (as Nizar already mentioned). I will leave this PR review to @lgp171188. Let me know @lgp171188 if you wont have time to make a review:
|
2b633a5 to
5ed758d
Compare
|
@lgp171188 @nizarmah sorry about that I didn't check the releases, only saw the change on master and started getting the commits. @lgp171188 this should be ready to test ty @s0b0lev for the review btw |
|
@eLRuLL, can you cherry-pick with the |
(cherry picked from commit c03857b)
5ed758d to
8b6cff5
Compare
|
oops, I forgot about that, @lgp171188 done |
lgp171188
left a comment
There was a problem hiding this comment.
👍
- I tested this and verified that this is a clean cherry-pick of the upstream fix and tested the changes on a sandbox and found no issues.
-
I read through the codeNA -
I checked for accessibility issuesNA -
Includes documentationNA
This cherry-picks security updates and fixes from https://github.com/edx/edx-platform/pull/25786 which are the same shared as patch for the 2020-12-03 XSS security fixes.
Testing Instructions:
Reviewers