SE-2092 Send user_logged_in when Mobile API user detail requested - #208
Merged
pomegranited merged 1 commit intoFeb 5, 2020
Conversation
so that it's triggered on initial app login and when app is re-launched. (cherry picked from commit 3b3c7bc)
samuelallan72
approved these changes
Feb 5, 2020
samuelallan72
left a comment
samuelallan72
left a comment
Member
There was a problem hiding this comment.
- I tested this: verified that it matched the original changes submitted to master/upstream. This has also been sanity checked on a test instance.
- I read through the code
- NA I checked for accessibility issues
- NA Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding
client'sconfiguration-securerepository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves user_logged_in signal to UserDetail.get so that it's triggered on initial app login and when app is re-launched.
cherry picked from commit 3b3c7bc, cf https://github.com/edx/edx-platform/pull/22999
Testing instructions
I believe the testing we did for the upstream PR is sufficient here. So it's just a straight backport cherry-pick, and there were no conflicts.
Reviewer