feat: xblock skill verification event - #1
Closed
navinkarkera wants to merge 2 commits into
Closed
Conversation
9 tasks
navinkarkera
force-pushed
the
navin/skill-tagging-events
branch
from
November 30, 2022 05:13
32d9664 to
df0fc92
Compare
tecoholic
requested changes
Dec 2, 2022
tecoholic
left a comment
tecoholic
left a comment
Member
There was a problem hiding this comment.
@navinkarkera Nice work here. I think you are a master of iterative development. :)
I have left a couple suggestions and a question linked to the location of the events in openedx/openedx-platform#31350. I will add the +1 once they are resolved.
navinkarkera
force-pushed
the
navin/skill-tagging-events
branch
from
December 5, 2022 13:14
df0fc92 to
4c815d8
Compare
navinkarkera
force-pushed
the
navin/verification-events
branch
2 times, most recently
from
December 5, 2022 13:57
1be5aa7 to
68e8b42
Compare
Member
Author
|
@tecoholic Thanks! Addressed all your comments.
Thank you! 😊 |
navinkarkera
force-pushed
the
navin/skill-tagging-events
branch
from
December 9, 2022 07:17
04b5014 to
1934a83
Compare
navinkarkera
force-pushed
the
navin/verification-events
branch
from
December 9, 2022 07:20
68e8b42 to
31b2256
Compare
tecoholic
approved these changes
Dec 12, 2022
tecoholic
left a comment
tecoholic
left a comment
Member
There was a problem hiding this comment.
@navinkarkera 👍 The PR looks good. I think you have missed updating the version for the package.
- I tested this: Relied on the unittests for the serializer as there are no testing instructions.
- I read through the code
- I checked for accessibility issues - NA
- Includes documentation
navinkarkera
force-pushed
the
navin/verification-events
branch
from
December 12, 2022 14:05
31b2256 to
77ad965
Compare
Member
Author
@tecoholic Ohh, thanks for catching it. Updated. |
7 tasks
navinkarkera
force-pushed
the
navin/skill-tagging-events
branch
3 times, most recently
from
January 4, 2023 13:04
faad90a to
75216de
Compare
navinkarkera
force-pushed
the
navin/verification-events
branch
from
January 4, 2023 13:07
77ad965 to
ec33782
Compare
9 tasks
Adds data class and event to send skill verification data for an XBlock. feat: add support for array avro types chore: add changelog docs: update signals docs to be more generic
navinkarkera
force-pushed
the
navin/verification-events
branch
from
January 4, 2023 13:10
ec33782 to
d3b4807
Compare
Member
Author
|
Replaced by openedx#165 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds data class and event to send skill verification data for an XBlock.
Updates avro serialization & de serialization just enough to support array types.
Description: The idea is that users will verify the tags/skills associated to an XBlock. We want to send this data via openedx-event signals to course-discovery and update the relevant tables.
JIRA:
Private-ref: BB-6885Dependencies: openedx#143
Merge checklist:
Post merge:
finished.
Author concerns: Only support for array type is added as it is required for this event.