Set EDXAPP_IMPORT_EXPORT_BUCKET to null - #206
Conversation
| @@ -0,0 +1 @@ | |||
| EDXAPP_IMPORT_EXPORT_BUCKET: null | |||
There was a problem hiding this comment.
@bradenmacdonald Ah thanks! I didn't know about the !! syntax. Just updated the branch.
|
Looks good, @replaceafill ! Conditional 👍 if you rebase and get the CI build to pass
|
|
@replaceafill I triggered a build for you. I'm not sure if our builds are working right now, but we'll see what happens. |
|
This is blocked until https://github.com/edx/edx-platform/pull/15101 is merged. Once that's merged, I'll cherry pick it into |
| # Workaround for broken CMS course export/import | ||
| # caused by https://github.com/edx/edx-platform/pull/14552 | ||
| template = loader.get_template('instance/ansible/ephemeral.yml') | ||
| return template.render() |
There was a problem hiding this comment.
@replaceafill Can we make sure to revert once the upstream PR is merged? To ensure we don't forget, I would only close the current ticket once both the upstream PR is merged and this reverted.
There was a problem hiding this comment.
@antoviaque This is actually more a fix than a workaround, and it has to be here as well as the upstream PR.
There was a problem hiding this comment.
Oh, right - forget my comment then. Sorry for the noise.
|
From @bradenmacdonald's comment above:
Could you rebase your pull request on master, and see if that fixes the test failures? |
|
@pomegranited I rebased this from 2dbbfe9. It's been a while now and I don't see any ci/circleci status yet. Can we re-trigger the ci/circleci check? |
|
@replaceafill I've triggered a build: https://circleci.com/gh/open-craft/opencraft/2189 Not sure why it's not showing up here though.. I might have done that wrong. But let's see how it goes. |
| @@ -61,7 +61,10 @@ def get_storage_settings(self): | |||
| Only needed when not using ephemeral databases | |||
There was a problem hiding this comment.
@replaceafill nit: Could you remove this comment? It doesn't apply anymore, since you've added ephemeral.yml.
There was a problem hiding this comment.
@pomegranited Removed. I also changed the EDXAPP_IMPORT_EXPORT_BUCKET setting to an empty string to be consistent with the change we made to the configuration repo.
4 participants
When using ephemeral databases this avoids S3 to be used as default storage for the CMS course import/export functionality.