Skip to content
This repository was archived by the owner on Mar 18, 2026. It is now read-only.

Add support for django 4.2 - #1

Closed
irtazaakram wants to merge 1 commit into
open-craft:masterfrom
irtazaakram:django42
Closed

Add support for django 4.2#1
irtazaakram wants to merge 1 commit into
open-craft:masterfrom
irtazaakram:django42

Conversation

@irtazaakram

Copy link
Copy Markdown

Hi,

This PR

  • adds support for Django 3.2 & 4.2
  • drops support for Django 1.11, 2.0 & 3.0
  • drops support for Python 2.7 & 3.6

Thanks,

@awais786

awais786 commented Sep 8, 2023

Copy link
Copy Markdown

@pomegranited please review this PR.

@awais786

awais786 commented Sep 18, 2023

Copy link
Copy Markdown

@bradenmacdonald can you please review this PR or ask some one from your team to make new one ?
it is blocking us on django42.

@bradenmacdonald

Copy link
Copy Markdown
Member

Hey @symbolist, is this plugin still used/needed on edx.org?

@symbolist

Copy link
Copy Markdown

@bradenmacdonald Nope. We are using our in process runtime now. Where exactly is this being referenced from?

I think all LabXchange specific code should have been removed in:
openedx/openedx-platform#31315
https://github.com/edx/edx-internal/pull/7420 (I do not have access to this)

@bradenmacdonald

Copy link
Copy Markdown
Member

Thanks @symbolist. As I thought, just wanted to confirm.

@awais786 I'm going to archive this repo - it shouldn't be used. If it's still installed on edx.org, please uninstall it and remove any associated database tables. Or do you need me to publish a "drop tables" migration first?

@awais786

Copy link
Copy Markdown

@bradenmacdonald Its coming from configuration repo.

git+https://github.com/open-craft/lx-pathway-plugin.git@ba1d470217cd5908cbd8b56075628bd4eacf7b39#egg=lx-pathway-plugin

I'll talk to Jeremy and then inform you. Thanks

@symbolist

symbolist commented Sep 19, 2023

Copy link
Copy Markdown

@awais786 Thanks! The package above it can also be removed:

git+https://github.com/open-craft/labxchange-xblocks.git@a0a8a8dad13199014d4bb29cee416289880bde0b#egg=labxchange-xblocks

@connorhaugh

Copy link
Copy Markdown

@bradenmacdonald and @symbolist

Looking at our mysql usage, it seems like we still have the lx_pathway table with data in it on prod. Making a quick drop tables migration would be great TYSM. After that is merged we can move to remove the plugin from configuration

Evidence of data in table:

mysql> SELECT COUNT() from lx_pathway_plugin_pathway;
+----------+
| COUNT(
) |
+----------+
| 6234 |
+----------+

Hooray for getting rid of unused things!

@awais786

Copy link
Copy Markdown

Thanks @symbolist. As I thought, just wanted to confirm.

@awais786 I'm going to archive this repo - it shouldn't be used. If it's still installed on edx.org, please uninstall it and remove any associated database tables. Or do you need me to publish a "drop tables" migration first?

@bradenmacdonald kindly make a pr for drop tables.

@symbolist

Copy link
Copy Markdown

@connorhaugh Sure.

@awais786 The LabXchange team will take care of this. Will get back.

@symbolist

Copy link
Copy Markdown

We have assigned this internally. Should be ready next week.

@awais786

Copy link
Copy Markdown

Thanks @symbolist

@pkulkark

Copy link
Copy Markdown
Member

@symbolist Sorry we missed that you mentioned someone from LabXchange team will take care of this. If they haven't yet done so, I have a PR for this: labxchange#17. CC @bradenmacdonald @awais786

@symbolist

Copy link
Copy Markdown

@pkulkark We were going to get to it this week so looks like you beat us to it. Thanks! 🙂

@bradenmacdonald

Copy link
Copy Markdown
Member

@symbolist or @awais786 would one of you[r teams] mind reviewing the PR?

@awais786

Copy link
Copy Markdown

@pkulkark PR seems fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants