feat: display profile name in navbar if available - #4
Merged
ArturGaspar merged 4 commits intoOct 1, 2024
Merged
Conversation
ArturGaspar
force-pushed
the
artur/update-user-navbar-quince
branch
from
September 20, 2024 06:06
6f95f09 to
b813085
Compare
ArturGaspar
changed the base branch from
opencraft-release/redwood.1
to
opencraft-release/redwood.krach-institute
September 24, 2024 00:12
ArturGaspar
changed the base branch from
opencraft-release/redwood.krach-institute
to
opencraft-release/redwood.1-krach-institute
September 24, 2024 00:17
Display profile name if it is set, else fallback to username
Cup0fCoffee
force-pushed
the
artur/update-user-navbar-quince
branch
from
September 26, 2024 13:00
ed74c5a to
517340d
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
tecoholic
approved these changes
Sep 30, 2024
tecoholic
left a comment
Member
There was a problem hiding this comment.
- I tested this: Installed the header locally using Tutor and verified that the name is shown in Course Authoring and Learning MFE
- I read through the code
- I checked for accessibility issues
- Includes documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Display profile name instead of username in header if available.
Port of #2.
Supporting information
#2
Testing instructions
npm install @edx/frontend-component-header@npm:@opencraft/frontend-component-header@~5.3.4-test; for Tutor, see https://github.com/overhangio/tutor-mfe/blob/master/README.rst#customising-mfes).Deadline
2024-10-15
Other information
Internal-ref: https://tasks.opencraft.com/browse/BB-9022