Skip to content

feat: display profile name in navbar if available - #4

Merged
ArturGaspar merged 4 commits into
opencraft-release/redwood.1-krach-institutefrom
artur/update-user-navbar-quince
Oct 1, 2024
Merged

feat: display profile name in navbar if available#4
ArturGaspar merged 4 commits into
opencraft-release/redwood.1-krach-institutefrom
artur/update-user-navbar-quince

Conversation

@ArturGaspar

@ArturGaspar ArturGaspar commented Sep 20, 2024

Copy link
Copy Markdown

Description

Display profile name instead of username in header if available.

Port of #2.

Supporting information

#2

Testing instructions

  1. Install this component (npm install @edx/frontend-component-header@npm:@opencraft/frontend-component-header@~5.3.4-test; for Tutor, see https://github.com/overhangio/tutor-mfe/blob/master/README.rst#customising-mfes).
  2. Set a user's name (in the Django admin that is the name in the UserProfile, not the first and last name fields).
    image
  3. Log out and log in again
  4. Check that the user's name now appears in the Course Authoring header
    image
  5. Check that the user's name now appears in the Learning header when viewing a course
    image

Deadline

2024-10-15

Other information

Internal-ref: https://tasks.opencraft.com/browse/BB-9022

@ArturGaspar
ArturGaspar force-pushed the artur/update-user-navbar-quince branch from 6f95f09 to b813085 Compare September 20, 2024 06:06
@ArturGaspar
ArturGaspar changed the base branch from opencraft-release/redwood.1 to opencraft-release/redwood.krach-institute September 24, 2024 00:12
@ArturGaspar
ArturGaspar changed the base branch from opencraft-release/redwood.krach-institute to opencraft-release/redwood.1-krach-institute September 24, 2024 00:17
@Cup0fCoffee
Cup0fCoffee force-pushed the artur/update-user-navbar-quince branch from ed74c5a to 517340d Compare September 26, 2024 13:00
@codecov

codecov Bot commented Sep 26, 2024

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@tecoholic tecoholic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ArturGaspar 👍

  • I tested this: Installed the header locally using Tutor and verified that the name is shown in Course Authoring and Learning MFE
  • I read through the code
  • I checked for accessibility issues
  • Includes documentation

@ArturGaspar
ArturGaspar merged commit f058185 into opencraft-release/redwood.1-krach-institute Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants