Skip to content

fix(redwood): send XBlock visibility status to the LMS - #35

Merged
Agrendalath merged 1 commit into
opencraft-release/redwood.1from
agrendalath/bb-8826-completion-in-the-learning-mfe-redwood
Sep 30, 2024
Merged

fix(redwood): send XBlock visibility status to the LMS#35
Agrendalath merged 1 commit into
opencraft-release/redwood.1from
agrendalath/bb-8826-completion-in-the-learning-mfe-redwood

Conversation

@Agrendalath

@Agrendalath Agrendalath commented Sep 25, 2024

Copy link
Copy Markdown
Member

Please see open-craft/openedx-platform#688

Private-ref: BB-8826

@Agrendalath Agrendalath self-assigned this Sep 25, 2024
@codecov

codecov Bot commented Sep 25, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (opencraft-release/redwood.1@a22759a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...re/course/sequence/Unit/hooks/useIFrameBehavior.js 94.11% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##             opencraft-release/redwood.1      #35   +/-   ##
==============================================================
  Coverage                               ?   88.82%           
==============================================================
  Files                                  ?      306           
  Lines                                  ?     5280           
  Branches                               ?     1311           
==============================================================
  Hits                                   ?     4690           
  Misses                                 ?      574           
  Partials                               ?       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Agrendalath
Agrendalath force-pushed the agrendalath/bb-8826-completion-in-the-learning-mfe-redwood branch from 5b4d655 to 7dc01bb Compare September 25, 2024 17:52
@Agrendalath
Agrendalath marked this pull request as ready for review September 25, 2024 18:04
@Agrendalath Agrendalath changed the title fix: send XBlock visibility status to the LMS fix(redwood): send XBlock visibility status to the LMS Sep 25, 2024

@farhaanbukhsh farhaanbukhsh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • ✅ I tested this on tutor
  • ✅ I read through the code
  • ❌ I checked for accessibility issues
  • ❌ Includes documentation
  • ❌ I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.

@Agrendalath
Agrendalath merged commit 1774b3f into opencraft-release/redwood.1 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants