fix: Rename optimistic update in children containers - #90
Conversation
pomegranited
left a comment
There was a problem hiding this comment.
👍 couple of lint issues but this is working well. I like the optimistic update behaviour, and would like to see it used everywhere.
I think we need a test or two though?
- I tested this on my devstack with and without a running CMS, to make sure that the optimistic update reverts if it cannot be saved.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
- User-facing strings are extracted for translation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## chris/FAL-4165-fix-name-in-unit-sidebar #90 +/- ##
==========================================================================
Coverage ? 94.02%
==========================================================================
Files ? 1163
Lines ? 24421
Branches ? 5194
==========================================================================
Hits ? 22961
Misses ? 1392
Partials ? 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Edit: I got confused, it's better to merge them separately because this one can't be backported to Teak |
Invalidates the query in the subsection page used to get the list of sections that contains the subsection
|
@ChrisChV Since this was targettng a branch on the open-craft fork, it doesn't need a CC review. I think you'll need to open a new PR if you want to merge it separately, and then I can review if you need. |
81802ab to
c5b1dd3
Compare
|
Closed in flavor of openedx#2141 |
Description
Supporting information
Testing instructions
Other information