fix: discard changes [FC-0062]

[navinkarkera]

Related PRs:

• fix: delete discarded components from meilisearch index [FC-0062] openedx/openedx-platform#35243
• feat: option to include deleted drafts while fetching unpublished entities [FC-0062] openedx/openedx-core#207

Issue: openedx#1200

Test instructions:

• Setup latest tutor nightly locally.
• Install https://github.com/open-craft/tutor-contrib-meilisearch and enable the plugin
• Checkout above PRs from edx-platform and openedx-learning.
• Mount both the directories in tutor using tutor mounts add <path>.
• Start tutor using tutor dev launch -I
• Go to studio -> Libraries and create a new library.
• Create some components and click on publish button in the sidebar.
• Verify that everything is saved.
• Add some more components and click on Discard changes button in sidebar.
• Verify that newly created components are not visible.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (chris/FAL-3760-library-info-sidebar@2ad5b1f). Learn more about missing BASE report.

Additional details and impacted files

@@                          Coverage Diff                           @@
##             chris/FAL-3760-library-info-sidebar      #58   +/-   ##
======================================================================
  Coverage                                       ?   92.97%           
======================================================================
  Files                                          ?      756           
  Lines                                          ?    13628           
  Branches                                       ?     2946           
======================================================================
  Hits                                           ?    12670           
  Misses                                         ?      922           
  Partials                                       ?       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChrisChV]

@navinkarkera Looks good, great work 👍

• I tested this: I followed the testing instructions. I tested with a new library, a tested after publish a library and I tested the discard changes with multiple updates
• I read through the code and considered the security, stability and performance implications of the changes.
• I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
• Includes tests for bugfixes and/or features added.
• Includes documentation
• Includes fixtures that create objects required for manual testing.

[bradenmacdonald]

Q: is it really necessary to invalidate all cached data related to content search?

Nit: it would be nice to convert this to the query key pattern like we're doing above for library authoring query keys.

[navinkarkera]

Q: is it really necessary to invalidate all cached data related to content search?

@bradenmacdonald Actually, I only want to invalidate content search queries related to this library. So updated the new PR: openedx#1214 to include this commit: openedx@9a3fc04

I tried changing content search queries to use query key pattern but it has a lot of dynamic variables and I could not think of a nice way to implement it.