feat: Avoid close Tags drawer on edit - #34
Conversation
yusuf-musleh
left a comment
There was a problem hiding this comment.
@ChrisChV Great work on this, the code looks good to me and it works well!
However I am still able to close the drawer when pressing escape even when there are unsaved changes. It might be worth adding some logic to the keypress handler to prevent it from closing when there are unsaved changes.
|
@yusuf-musleh Thanks for the review!
Thanks for catch that! I fixed that here: f4d7e04 |
yusuf-musleh
left a comment
There was a problem hiding this comment.
👍 @ChrisChV Great work! Thanks for addressing the issue, its working as expected. For the codecov issue that is failing in the CI, sometimes it gets fixed when re-triggering the CI to run again, I usually do that by doing git commit --amend --noedit and then force pushing, it makes no changes to the code, just changes the commit hash because we are amending (nothing) to it.
- I tested this: Followed testing instructions
- I read through the code
- I checked for accessibility issues
-
Includes documentation
f4d7e04 to
dc44778
Compare
2e5c81f to
cdaf7b5
Compare
44b40ed to
9483bac
Compare
b491d9b to
8110861
Compare
It contains different changes to achieve the reading and editing mode of the drawer tag: * Manage tags drawer footer with buttons added. * Creation of ContentTagsDrawerContext. * Creation of global state and global removed state to allow edit mode. * Update API client to match with openedx-learning 0.9.1: Save tags of multiple taxonomies; to save all tags added/removed on edit mode * Extract TagsTree and use it on the Tags Drawer. * Update TagsTree to allow edit mode. * Add a Toast on Tags Drawer; show the toast afert save. * Scrolling + sticky footer on tags drawer
* Avoid close Tags drawer on edit
* To avoid lose user data
* Wrap with ContentTagsDrawerSheet to build drawer on MFE
* ContentTagsDrawerSheetContext created
* Not close drawer with Escape is pressed when container is blocked
d36bf33 to
73c978b
Compare
|
Close in favor of openedx#965 |
Description
Supporting information
Testing instructions
make requirementson cms shell.Edit tagsEdit tags