[FC-0036] feat: tags drawer style refinements - #32
Merged
ChrisChV merged 8 commits intoApr 10, 2024
Merged
Conversation
yusuf-musleh
force-pushed
the
yusuf-musleh/tags-drawer-style-refinements
branch
from
April 9, 2024 11:04
c926b37 to
7762945
Compare
yusuf-musleh
force-pushed
the
yusuf-musleh/tags-drawer-style-refinements
branch
from
April 9, 2024 13:04
f088500 to
ad15c04
Compare
yusuf-musleh
marked this pull request as ready for review
April 9, 2024 13:07
…gs-drawer-style-refinements
ChrisChV
approved these changes
Apr 10, 2024
ChrisChV
left a comment
Member
There was a problem hiding this comment.
@yusuf-musleh Looks good 👍
- I tested this: I checked all style changes listened here
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes styling updates to the tags drawer and fixes the issue with scrolling.
Supporting Information
Related PR:
Testing Instruction
Private-ref: FAL-3645