feat: import tags to existing taxonomy - #11
Conversation
pomegranited
left a comment
There was a problem hiding this comment.
This is looking good @rpenido , just needs linting and tests.
Could you also make sure the new "Re-import" menu item is added to the "Actions" menu on the Taxonomy Detail page too?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## rpenido/fal-3532-import-taxonomy #11 +/- ##
===================================================================
Coverage ? 88.77%
===================================================================
Files ? 449
Lines ? 6924
Branches ? 1470
===================================================================
Hits ? 6147
Misses ? 752
Partials ? 25 ☔ View full report in Codecov by Sentry. |
04b6c6e to
c055d56
Compare
pomegranited
left a comment
There was a problem hiding this comment.
👍 one nit, but LGTM!
@bradenmacdonald can @rpenido merge this into openedx#675 and get both these "import tags" features reviewed by upstream at once?
- I tested this on my devstack. There's a known issue with re-importing tags that affects the backend logic, but
- I read through the code (on #11)
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
- User-facing strings are extracted for translation
Co-authored-by: Jillian <jill@opencraft.com>
Yes please! |
Done! openedx#675 |
Description
This PR adds a new menu item in the Taxonomy Card menu and the Taxonomy Details menu to allow users to import tags to existing Taxonomies by importing a CSV/JSON file. This overwrites the current tags.
Testing instructions
Private-ref: FAL-3536