feat: per-user secured Algolia API keys [BB-8083][BACKPORT] - #12
Merged
Agrendalath merged 4 commits intoNov 21, 2023
Merged
Conversation
0x29a
changed the title
Co-authored-by: Piotr Surowiec <piotr@surowiec.it> (cherry picked from commit 3c9c3dc)
0x29a
force-pushed
the
0x29a/bb8083/per-user-algolia-key-nutmeg
branch
from
November 18, 2023 14:07
773fb2d to
d6872b5
Compare
0x29a
commented
Nov 18, 2023
Comment on lines
+690
to
+691
| # TODO: Backport https://github.com/openedx/edx-ora2/pull/1869 to Olive if it uses a lower version than 4.5.0. | ||
| ora2 @ git+https://github.com/open-craft/edx-ora2@agrendalath/bb-6151-nutmeg_backport |
Author
There was a problem hiding this comment.
This and py2neo have been pulled automatically by make upgrade.
Agrendalath
approved these changes
Nov 18, 2023
Agrendalath
left a comment
Agrendalath
left a comment
Member
There was a problem hiding this comment.
👍
- I tested this: checked that the cherry-pick matches the original PR
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backported from #11.
Check open-craft/frontend-app-learner-portal-enterprise#2 for additional testing notes for Nutmeg.