This repository was archived by the owner on Mar 18, 2026. It is now read-only.
SE-1617 Allows setting default currency from environment - #13
Merged
pomegranited merged 1 commit intoFeb 26, 2020
Merged
Conversation
samuelallan72
approved these changes
Feb 25, 2020
samuelallan72
left a comment
samuelallan72
left a comment
Member
There was a problem hiding this comment.
- I tested this: verified that this correctly updates the default currency on a client's instance.
- I read through the code
- NA I checked for accessibility issues
- NA Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding
client'sconfiguration-securerepository (ocim).
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows ecommerce deployments to configure their default currency via ansible. Default is set to
"USD"in the ecommerce platform.Upstream PR: https://github.com/edx/ecommerce/pull/2916
Dependencies: open-craft/configuration#119
Sandbox URL: Tested on client instance.
Testing instructions:
See open-craft/configuration#119
Reviewers