This repository was archived by the owner on Aug 3, 2026. It is now read-only.
[SE-3381] Clears existing node modules before installing npm dependencies - #141
Merged
nizarmah merged 4 commits intoOct 18, 2020
Merged
Conversation
nizarmah
force-pushed
the
nizar/autodesk_clear_npm_modules
branch
2 times, most recently
from
October 11, 2020 22:46
495ec32 to
519e5b0
Compare
nizarmah
force-pushed
the
nizar/autodesk_clear_npm_modules
branch
from
October 12, 2020 07:01
100ce85 to
f359e61
Compare
pkulkark
approved these changes
Oct 15, 2020
pkulkark
left a comment
pkulkark
left a comment
Member
There was a problem hiding this comment.
@nizarmah Changes LGTM 👍
- I tested this: I did not spawn new instance but verified all other steps mentioned in the testing instructions on the STG instance
- I read through the code
-
I checked for accessibilityN/A -
Includes documentationN/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the latest changes on the edx-platform regarding
JakePackage.zip, thenode_modulesneeds to be cleared, so that the npm dependencies can install successfully without any error. Also the existing minified files need to be cleaned too usingnpx jake clean-jsso that we always generate new minified files.Related to PR: open-craft/openedx-platform#275
JIRA tickets: SE-3381, SE-3101
Testing instructions:
adsklinkplugin works in Studio in TinyMCE editoredx-platform/common/static/js/vendor/tinymceplugin.min.jswere generated correctly using:grep -Er "^undefined$"commons.jsfile hash is consistent on different machinesAuthor notes and concerns:
Reviewers