This repository was archived by the owner on Aug 3, 2026. It is now read-only.
Remove AppleId third party backend from defaults - #140
Merged
kaizoku merged 1 commit intoOct 9, 2020
Conversation
|
Thanks for fixing this so quickly @kaizoku ! I'm testing it with a new appserver now. |
pomegranited
approved these changes
Oct 9, 2020
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
👍 Thank you @kaizoku !
- I tested this by provisioning a juniper.3 Ocim appserver with
EDXAPP_THIRD_PARTY_AUTH_BACKENDSset to match the amended list here. - I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
I made sure any change in configuration variables is reflected in the correspondingN/A
client'sconfiguration-securerepository.
Author
|
Thank you for investigating and identifying the issue here @pomegranited! |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration Pull Request
This fixes an issue introduced in #136 from a backported default variable mistakenly including
third_party_auth.appleid.AppleIdAuthinTHIRD_PARTY_AUTH_BACKENDSwhich is unavailable in Juniper.