SE-2170 Port changes not yet merged to upstream into our juniper release branch #225 - #129
Conversation
Allow setting SiteConfiguration values for the default site or a specific site by id or domain when provisioning an instance. (cherry picked from commit e805a57)
(cherry picked from commit 40c5a89)
Setting this variable to `True` disables handling the IP disclosure within private subnetworks. (cherry picked from commit 8a79772)
…ix issues (cherry picked from commit af69623)
|
There doesn't seem to be any Pull Requests in those cherry picked commits. Do I just need to just follow the test instructions on open-craft/openedx-platform#225, without testing anything in this pull request? Please let me know when possible @pomegranited |
Sorry, I didn't edit the cherry-picked commits for this repo to add the pull request #. But if you follow the "cherry-picked from" revision link, github will show you the open PR it's related to. For the ecommerce one, I haven't taken the trouble of setting up ecommerce on this test instance, because that's a bit involved. If you could just check that the cherry-pick went in cleanly and that the variable is still in use in the ecommerce config, that should be enough. |
|
Alright, no worries @pomegranited, thank you for getting back to me about this though! |
|
Status of reviewing the cherry picked commits:
Regarding commit
I can confirm that the variable is still in use in the ecommerce config on Regarding commit |
There was a problem hiding this comment.
👍
- I tested this through:
- Testing each cherry picked commit's pull request:
- Read through the code
- Followed the testing instructions for each pull request
- I read through the code
-
I checked for accessibility issues -
Includes documentation -
I made sure any change in configuration variables is reflected in the corresponding client'sconfiguration-securerepository.
cf https://github.com/edx/configuration/pull/5884 (cherry picked from commit a027b4b)
5 participants
This branch starts with the tagged upstream
open-release/juniper.2, and adds in the code drift that was present inopencraft-release/ironwood.2which has not yet been merged upstream.See open-craft/openedx-platform#225 for testing instructions.
Reviewer
CC @lgp171188