Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyData theme #37

Open
jpmckinney opened this issue Sep 19, 2020 · 7 comments
Open

Switch to PyData theme #37

jpmckinney opened this issue Sep 19, 2020 · 7 comments
Assignees

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Sep 19, 2020

standard_theme has not been kept up-to-date with its upstream (open-contracting/standard_theme#8). standard_theme also has a variety of issues like the single sidebar mixing in-page and between-page navigation.

We can see what we added in our open_contracting branch, to check if there is anything to carry over to sphinx-book-theme (which we should try to carry-over in a way that makes it easy to track upstream). ✅

Helpful docs, to which we can add a link from standard-development-handbook: ✅

Inspiration

@jpmckinney jpmckinney changed the title Consider switch to sphinx-book-theme Consider switching theme Sep 19, 2020
@jpmckinney
Copy link
Member Author

As of quite recently, JupyterBook and dependencies have been refreshed: https://jupyterbook.org/reference/_changelog.html#v0-8-0-2020-09-01

@jpmckinney
Copy link
Member Author

jpmckinney commented Sep 29, 2020

  • We should use color and shadow to create "layers" like in Google's API docs. Otherwise, it's easy to not notice the right-hand menu.
  • We should think through how to interlink the different documentation websites via the top navigation, e.g. Profiles (and OC4IDS), Tools (data service, flattening tool)

Added to checklist at open-contracting/standard#1254 (comment)

@jpmckinney
Copy link
Member Author

jpmckinney commented Feb 2, 2021

A reminder that I'll need to update the crawler for the new theme: open-contracting/ocds-index#6
Done

@jpmckinney
Copy link
Member Author

jpmckinney commented Feb 14, 2021

Comment moved to #36 (comment)

@jpmckinney
Copy link
Member Author

jpmckinney commented Mar 19, 2021

A follow-up issue will be to restore a good print stylesheet, and test its output with make pdf.
Created #44

@jpmckinney
Copy link
Member Author

jpmckinney commented Apr 22, 2021

The relevant features have been documented at https://ocds-standard-development-handbook.readthedocs.io/meta/markdown_style_guide.html

Work continues in open-contracting/standard#1254 (comment)

To close this issue, the theme will need to be implemented in this template and in the other documentation repositories.

@jpmckinney jpmckinney changed the title Consider switching theme Switch to PyData theme Apr 22, 2021
@jpmckinney jpmckinney self-assigned this Apr 22, 2021
@jpmckinney
Copy link
Member Author

jpmckinney commented Jan 29, 2023

See also this heuristic evaluation of a draft version of the theme: https://docs.google.com/document/d/1qylhtpuptvxgvgPaUxtzVd5vblNzeqMLDYY2B26HQcg/edit

The document is in this folder: https://drive.google.com/drive/u/0/folders/1fWbDjAYmNYft475Xv7NPb0-SPTFSB0iM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant