Extract margin directive to separate repository

[jpmckinney]

I'm using the PyData theme, but it would be nice to be able to use the margin directive. Would it be possible to extract it?

[welcome]

Thanks for opening your first issue here! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.

If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).

Welcome to the EBP community! 🎉

[choldgraf]

The main challenge is that it'd conflict with the elements on another theme, and is kind of context dependent. Eg, how would you deal with the overlap between the margin and the in-page TOC?

[jpmckinney]

The Python code seems to have nothing specific to this theme, besides adding the margin CSS class: https://github.com/executablebooks/sphinx-book-theme/blob/master/sphinx_book_theme/__init__.py#L257-L273

Obviously, like any directive, I'd have to style it myself, using the CSS in:

https://github.com/executablebooks/sphinx-book-theme/blob/d34858003df2c582e91f9528efade676e1cc434f/src/scss/_page.scss
https://github.com/executablebooks/sphinx-book-theme/blob/7239788bc1fb4b02b4442be53c6e17f38e843a63/src/scss/_print.scss

[jpmckinney]

But, yeah, without the CSS, I guess it is basically the same as the sidebar directive from docutils?

[choldgraf]

Ah interesting - we certainly could just add a super lightweight python package that added a margin directive. Would that help? Or maybe it'd be easier just to add your own margin directive?

[jpmckinney]

I'm going to try out the plain sidebar and see how far i get :)