Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abandon in-file translations, document full-file translation guidance #1665

Merged
merged 11 commits into from
Dec 14, 2023
Merged

Abandon in-file translations, document full-file translation guidance #1665

merged 11 commits into from
Dec 14, 2023

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst commented Nov 29, 2023 •
edited by jpmckinney
Loading

@duncandewhurst duncandewhurst marked this pull request as ready for review November 29, 2023 23:51
jpmckinney
jpmckinney reviewed Dec 4, 2023
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this closes #1064, which wants to cover translations of extensions.

I'll make translations.md copy-edits directly.

We can delete examples/language_localization/language.csv and its language.json

I updated manage.py to make these nontranslatable: postalCode, email, telephone, faxNumber, milestone code. These have publisher-specific formats or codelists, or are missing a validation property like "format": "email" #881.

Comparing i18n.csv to the patternProperties, we've removed deprecated fields (good) and added:

  • These 3 address components can indeed be translated
    • Address.locality
    • Address.region
    • Address.streetAddress
  • I suppose we just missed these 3 originally:
    • Amendment.description
    • RelatedProcess.title
    • Tender.procurementMethodDetails
  • These fields are new:
    • Award.statusDetails
    • Contract.statusDetails
    • Tender.statusDetails
    • Tender.exclusionGrounds

Also, in OCDS 1.0, Organization.name was translatable. In OCDS 1.1, OrganizationReference.name was not translatable. In OCDS 1.2, both are translatable. In other words, both buyer/name and the .name of the corresponding entry in the parties array are translatable. This is good.

docs/guidance/map.md Outdated Show resolved Hide resolved
docs/schema/reference.md Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

I've pushed my edits to the new guidance page, for review.

@jpmckinney
guidance/map/translations: Rewrite with simpler structure
343ff2b 
- Clarify that this page is for sources with distinct fields for each language. If a field mixes languages, this page is not relevant.
- Clarify that translated text must have the same content across translations.
- Instead of a long list of repetitive field names, summarize the patterns.
@duncandewhurst
Copy link
Contributor Author

We can delete examples/language_localization/language.csv and its language.json

Done in 37a024a

The revised guidance page and the changes to manage.py look good to me.

@jpmckinney jpmckinney merged commit d05cecf into 1.2-dev Dec 14, 2023
10 checks passed
@jpmckinney jpmckinney deleted the 229-translations branch December 14, 2023 01:58
@jpmckinney jpmckinney added this to the 1.2.0 milestone Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odscjen odscjen odscjen approved these changes

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OCDS 1.2
Status: Done
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.

Abandon in-file translations, document full-file translation guidance
3 participants
@duncandewhurst @jpmckinney @odscjen