schema: Include release date uniqueness definition in its description #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmckinney
reviewed
Nov 11, 2021
schema/release-schema.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| }, | |||
| "date": { | |||
| "title": "Release Date", | |||
| "description": "The date on which the information contained in the release was first recorded in, or published by, any system. For a compiled release, the maximum `date` among the individual releases used to create the compiled release.", | |||
| "description": "The date on which the information contained in the release was first recorded in, or published by, any system. The release date should be unique within the scope of the contracting process identified by the Open Contracting ID (ocid), for a given version of OCDS. For a compiled release, the maximum `date` among the individual releases used to create the compiled release.", | |||
There was a problem hiding this comment.
The part about the compiled release is not a full sentence - it's the alternative definition in case of a compiled release. So, I think it has to appear before the full sentence about uniqueness.
Suggested change
| "description": "The date on which the information contained in the release was first recorded in, or published by, any system. The release date should be unique within the scope of the contracting process identified by the Open Contracting ID (ocid), for a given version of OCDS. For a compiled release, the maximum `date` among the individual releases used to create the compiled release.", | |
| "description": "The date on which the information contained in the release was first recorded in, or published by, any system. For a compiled release, the maximum `date` among the individual releases used to create the compiled release. The release date should be unique within the scope of the contracting process identified by the Open Contracting ID (ocid), for a given version of OCDS.", |
|
Also, does this close #848 or only ref it? |
I'm not sure if we should close that issue or change it to OCDS 2.0 after we merge this one, as for OCDS 2.0 we may want to change the definition again from "should" to "must". |
|
OCDS 2.0 has a lot of rules that might need to change, but we haven't started OCDS 2.0, so we don't need issues for those types of things yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #848