Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update definition of award #1175

Merged
merged 16 commits into from
Sep 18, 2021
Merged

Update definition of award #1175

merged 16 commits into from
Sep 18, 2021

Conversation

JachymHercher
Copy link
Contributor

@JachymHercher JachymHercher commented Jan 20, 2021

closes #895

@jpmckinney jpmckinney added this to the 1.2.0 milestone Feb 5, 2021
@jpmckinney
Copy link
Member

@JachymHercher We didn't discuss this one. What is keeping it in draft?

@JachymHercher
Copy link
Contributor Author

Two things:

@jpmckinney
Copy link
Member

Still waiting for the resolution of #1160, which might add a sentence to the definition.

I've lost track of what needs to be resolved. Can you summarize?

@JachymHercher
Copy link
Contributor Author

I've made a summary in #1160 (comment) and I think there probably won't be any implications for the description of award, assuming we explain it in the guidance and other places. I'll add the changelog and submit the PR.

@JachymHercher JachymHercher marked this pull request as ready for review March 7, 2021 20:50
@JachymHercher JachymHercher requested a review from jpmckinney March 7, 2021 20:50
@JachymHercher JachymHercher added Focus - Documentation Includes corrections, clarifications, new guidance, and UI/UX issues Semantics Relating to field and code descriptions labels Mar 7, 2021
@JachymHercher JachymHercher linked an issue Mar 7, 2021 that may be closed by this pull request
docs/history/changelog.md Outdated Show resolved Hide resolved
docs/history/changelog.md Outdated Show resolved Hide resolved
schema/release-schema.json Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

Since the comments might be collapsed, note a long thread in #1175 (comment)

@jpmckinney jpmckinney removed Focus - Documentation Includes corrections, clarifications, new guidance, and UI/UX issues Semantics Relating to field and code descriptions labels Jul 31, 2021
@jpmckinney
Copy link
Member

In a8eae81 I had to remove the last sentence with the link the GitHub, because while that issue does happen to discuss many-to-one awards-to-contracts, it is not the primary subject of the issue, and so readers are likely to be confused (especially if we close it per the primary subject).

@jpmckinney jpmckinney added the unresolved-suggestions To filter pull requests with unresolved suggestions label Sep 2, 2021
@JachymHercher
Copy link
Contributor Author

Makes sense. Are we good to merge?

@jpmckinney jpmckinney merged commit f27a570 into 1.2-dev Sep 18, 2021
@jpmckinney jpmckinney deleted the 895-award-definition branch September 18, 2021 22:48
@jpmckinney jpmckinney removed the unresolved-suggestions To filter pull requests with unresolved suggestions label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Clarify award description
2 participants