Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String identifiers preference #1086

Merged
merged 5 commits into from
Oct 23, 2020
Merged

String identifiers preference #1086

merged 5 commits into from
Oct 23, 2020

Conversation

yolile
Copy link
Member

@yolile yolile commented Oct 12, 2020

Closes #789

duncandewhurst
duncandewhurst requested changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Please can you update the changelog?

@yolile
Copy link
Member Author

yolile commented Oct 22, 2020

done!

@yolile yolile merged commit 7a4f4fd into 1.2-dev Oct 23, 2020
@yolile yolile deleted the 789-string-identifiers-preference branch October 23, 2020 16:17
@jpmckinney jpmckinney added this to the 1.2.0 milestone Nov 11, 2020
@duncandewhurst duncandewhurst mentioned this pull request Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

@duncandewhurst duncandewhurst Awaiting requested review from duncandewhurst

Assignees
No one assigned
Labels
None yet
Projects
OCDS 1.2
Status: Done
Milestone
1.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@yolile @jpmckinney @duncandewhurst