Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all content translating into Spanish #142

Closed
sabahfromlondon opened this issue Apr 29, 2021 · 17 comments
Closed

Not all content translating into Spanish #142

sabahfromlondon opened this issue Apr 29, 2021 · 17 comments
Milestone

Comments

@sabahfromlondon
Copy link

When I switch from English to Spanish not all of the content is translated.

See x2 screenshots attached. It can be seen that:

  • The body text is not translated
  • The content in the FAQs on the right hand side is not t
    ranslated the the text that is hyperlinked is.

I have not checked the remainder of the screens.

Spanish translation issue

Spanish translation issue 2

@sabahfromlondon
Copy link
Author

Also noticed the Spanish user friendly headings and Spanish R headings are not always being applied.

screencapture-ocp12-open-contracting-org-2021-04-29-11_49_26

@sorenabell
Copy link
Contributor

About the content of the page - it should be translated via Transifex. I added a couple of translations to just check the work of the tool, but all of the rest requires a Spanish translator's work.

As for the headings, we will check.

@jpmckinney
Copy link
Member

Yes, I think the process can be:

  • OCP reviews the English text and makes edits as desired
  • OCP coordinates the Spanish translation, to be done in Transifex
  • Quinta pulls in the Spanish translations from Transifex

@sorenabell
Copy link
Contributor

You can use this Chrome extension to annotate text on the website. Just add your comments to the corresponding group (join it previously).
image

@sorenabell
Copy link
Contributor

We have planned to add a mechanism that pulls the changes from Transifex automatically and periodically.
@jpmckinney maybe every night?

@jpmckinney
Copy link
Member

I'm not familiar with that workflow. Usually, if we add/change the English text, then we manually push to Transifex, ask the translators to make updates, and then manually pull from Transifex, before deploying the new version, so that the live version is always 100% translated.

We don't expect strings to change in Transifex between such processes.

@sorenabell sorenabell added this to the Production ready 1.0 milestone Apr 29, 2021
@sorenabell sorenabell removed this from the Production ready 1.0 milestone May 19, 2021
@jpmckinney
Copy link
Member

FYI @yolile

@yolile
Copy link
Member

yolile commented May 19, 2021

Also noticed the Spanish user friendly headings and Spanish R headings are not always being applied.

And also, when selecting "English" some columns are in Spanish

image

@jpmckinney
Copy link
Member

@yolile or @sabahfromlondon: Can you check whether this is complete?

@yolile
Copy link
Member

yolile commented Aug 12, 2021

There are still some untranslated strings
screenshot_1

screenshot_2
screenshot_3

And #142 (comment) problem remains, but not sure if that one is related to the columns translation.

@sorenabell
Copy link
Contributor

For some reason, those translated lines were pulled from Transifex but not applied on the UI. We ran the build once more and now most of the lines are translated on production.
Just "There are * arrays in this table" needs the translation in Transifex now.

@sabahfromlondon
Copy link
Author

@sorenabell I've found a few more places where the content is not translating into Spanish. See screenshots below:

Upload screen - see text in FAQ box:
Screenshot 2021-08-24 085601

Pop up box when clicking upload step
Screenshot 2021-08-24 085623

Text for arrays not translating:
Screenshot 2021-08-24 090002
Screenshot 2021-08-24 090053

When selecting to remove a table - I believe the Spanish for Cancel is Cancelar - I've see this happen to array tables and main tables
Screenshot 2021-08-24 090134

@yolile
Copy link
Member

yolile commented Aug 25, 2021

When selecting to remove a table - I believe the Spanish for Cancel is Cancelar

@sabahfromlondon you are right 😄

@sorenabell I translated all the available strings in the Spanish resource in Transifex now. However, I don't see the strings from the pop-ups there.

@sorenabell sorenabell mentioned this issue Aug 26, 2021
3 tasks
@sorenabell
Copy link
Contributor

We've fixed all UI translation issues for Spanish and Russian.
https://www.awesomescreenshot.com/video/5361074?key=2862463c16caa0770e2359f446044432
Please check it on staging https://ocp12.open-contracting.org/

Please also check Transifex for any new untranslated lines from new UI flows or error messages.

@sabahfromlondon
Copy link
Author

@sorenabell I've done a check and all the issues above look like they have been resolved.

Did you have a link to the page when the user comes from the Data Registry? I will check that too.

Thanks

@sorenabell
Copy link
Contributor

@sabahfromlondon No, the previous workaround doesn't work now, we will have to wait for #347

@sabahfromlondon
Copy link
Author

Ok well sounds like we can close this ticket then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants