Skip to content

Commit

Permalink
chore: item is always set (SELECT FROM), closes #47
Browse files Browse the repository at this point in the history
  • Loading branch information
jpmckinney committed Aug 14, 2023
1 parent e47a060 commit 793eb4b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions time_variance/checks/ocid.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@


def filter(scope, item, item_id, new_item, new_item_id):
return bool(item)
return True


def evaluate(scope, item, item_id, new_item, new_item_id):
# `time_variance/processor.py` currently tests whether `new_item` is truthy before calling `evaluate`, and the
# `filter` function above tests whether `item` is truthy, such that this function will always return `True`.
# Nonetheless, the code is preserved in case the logic in `time_variance/processor.py` is changed.
return scope, bool(item and new_item)
return scope, bool(new_item)
2 changes: 1 addition & 1 deletion time_variance/checks/phase_stable.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


def filter(scope, item, item_id, new_item, new_item_id):
return bool(item)
return True


def evaluate(scope, item, item_id, new_item, new_item_id):
Expand Down

0 comments on commit 793eb4b

Please sign in to comment.