Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with SqlMagic (prettytable) and arrow dependency conflict #74

Closed
wants to merge 1 commit into from

Conversation

ColinMaudry
Copy link
Member

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ColinMaudry
Copy link
Member Author

I'll fix the linting

@ColinMaudry ColinMaudry marked this pull request as draft November 22, 2024 16:18
@yolile
Copy link
Member

yolile commented Nov 22, 2024

Thanks, please also remember to clear all outputs https://github.com/open-contracting/notebooks-ocds?tab=readme-ov-file#commit-your-changes

@ColinMaudry
Copy link
Member Author

I didn't manage to figure out what is wrong with the CI. pre-commit output is all green on my side.

@ColinMaudry
Copy link
Member Author

ColinMaudry commented Nov 22, 2024

My outputs were clear, I think it's because I was editing locally on VS Code, which doesn't insert the same metadata in the files. I'll do a new PR using Colab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants