Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organization classifications #445

Merged
merged 11 commits into from
Nov 28, 2023
Merged

Organization classifications #445

merged 11 commits into from
Nov 28, 2023

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst duncandewhurst commented Nov 22, 2023 •
edited
Loading

Related issues

Description

Merge checklist

If there are changes to project-schema.json or project-package-schema.json:

  • Update the examples:
    • docs/examples/example.json
    • docs/examples/blank.json
  • Run ./manage.py pre-commit to update docs/_static/i8n.csv

If you added a new definition to the schema, run ./manage.py pre-commit.

If you added a new codelist:

  • Add an entry to docs/reference/codelists.md

@duncandewhurst duncandewhurst marked this pull request as ready for review November 22, 2023 02:40
odscjen
odscjen approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@odscjen odscjen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jpmckinney
jpmckinney reviewed Nov 24, 2023
View reviewed changes
schema/project-level/codelists/classificationScheme.csv Outdated Show resolved Hide resolved
schema/project-level/project-schema.json Outdated Show resolved Hide resolved
schema/project-level/project-schema.json Outdated Show resolved Hide resolved
schema/project-level/project-schema.json Outdated Show resolved Hide resolved
schema/project-level/project-schema.json Outdated Show resolved Hide resolved
jpmckinney
jpmckinney approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to merge if two three small comments resolved.

docs/reference/changelog.md Outdated Show resolved Hide resolved
schema/project-level/project-schema.json Outdated Show resolved Hide resolved
@duncandewhurst duncandewhurst merged commit 2fb2f44 into 0.9-dev Nov 28, 2023
10 checks passed
@duncandewhurst duncandewhurst deleted the 436-organization-classifications branch November 28, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

@odscjen odscjen odscjen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Organization classifications: Geographic scope and high-level sector
3 participants
@duncandewhurst @jpmckinney @odscjen