Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use install_recommends: False in aws/init.sls? #536

Closed
ocp-deploy opened this issue Jan 6, 2025 · 2 comments
Closed

Use install_recommends: False in aws/init.sls? #536

ocp-deploy opened this issue Jan 6, 2025 · 2 comments
Assignees
Milestone

Comments

@ocp-deploy
Copy link

@RobHooper From Dogsbody in December:

we have just patched a number of C++ packages on ocp27...

libgcc-13-dev
libstdc++-13-dev
g++-13
gcc-13
cpp-13-x86-64-linux-gnu
cpp-13
g++-13-x86-64-linux-gnu
gcc-13-x86-64-linux-gnu
gcc-13-base

... these packages are typically only on systems where you have compiled some code.
I wanted to let you know that if this is the case then you may need to recompile your code to include the security updates above.

If I’m not mistaken, ocp27 uses a PostgreSQL backup script that installs the awscli pip package, which requires python3-pip, which in turn has Recommends: build-essential, which then depends on gcc, etc.

Should we set install_recommends: False in salt/aws/init.sls, and also uninstall build-essential?

@ocp-deploy ocp-deploy added this to the Priority milestone Jan 6, 2025
@jpmckinney jpmckinney changed the title ocp27: Use install_recommends: False in aws/init.sls? Use install_recommends: False in aws/init.sls? Jan 6, 2025
@RobHooper
Copy link
Contributor

RobHooper commented Jan 7, 2025

I have just tested this on a dev server and I can confirm we can remove build-essential without effecting the aws-cli install.
We should action as suggested: set install_recommends: False and uninstall build-essential.

@jpmckinney jpmckinney self-assigned this Jan 7, 2025
@jpmckinney
Copy link
Member

Ok, I've made the Salt change and purged build-essential on ocp21, ocp23, ocp25 and ocp27, then ran autoremove, which removed:

ocp21: g++, g++-11, libstdc++-11-dev
ocp23: g++, g++-11, libstdc++-11-dev
ocp25: g++, g++-11, libstdc++-11-dev
ocp27: g++, g++-13, g++-13-x86-64-linux-gnu, g++-x86-64-linux-gnu, libstdc++-13-dev

jpmckinney added a commit that referenced this issue Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants