Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

96 full name country #381

Merged
merged 11 commits into from
Dec 10, 2024
Merged

96 full name country #381

merged 11 commits into from
Dec 10, 2024

Conversation

yolile
Copy link
Member

@yolile yolile commented Dec 5, 2024

closes #96

@yolile yolile requested a review from jpmckinney December 5, 2024 19:42
@yolile
Copy link
Member Author

yolile commented Dec 6, 2024

@jpmckinney note that I took the simpler approach here, but maybe we want a search box and return the country names as a separate service from the backend, instead of the current approach of having the list of country names as a dropdown

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple fixes directly.

data_registry/templates/search.html Dismissed Show dismissed Hide dismissed
@jpmckinney
Copy link
Member

@jpmckinney note that I took the simpler approach here, but maybe we want a search box and return the country names as a separate service from the backend, instead of the current approach of having the list of country names as a dropdown

I prefer making all options visible, like with a dropdown. We can maybe consider making the dropdown searchable, but it feels okay to me to scan an alphabetical list.

@yolile
Copy link
Member Author

yolile commented Dec 9, 2024

Thanks, sharing here what the dropdown looks like now, for reference
image

Do you think we should indicate somewhere what the numbers beside each country name are or is it obvious?

From the issue, you also said:

We can decide whether to have an info icon and tooltip to explain that unlisted countries have no datasets (that is the only reason I can think of for using letters).

Maybe we could include the tooltip with the explanation about missing countries and the number of datasets

@jpmckinney
Copy link
Member

We have numbers next to all the other facets. If there's a UX issue, it's widespread (beyond this PR).

You can open a new issue about the tooltip. There are several issues that can be closed at once, when tooltips are implemented.

@yolile yolile merged commit 8d8b13c into main Dec 10, 2024
15 of 17 checks passed
@yolile yolile deleted the 96-full-name-country branch December 10, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full-name country filter (was: Landing pages per country)
2 participants