-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
96 full name country #381
96 full name country #381
Conversation
@jpmckinney note that I took the simpler approach here, but maybe we want a search box and return the country names as a separate service from the backend, instead of the current approach of having the list of country names as a dropdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple fixes directly.
I prefer making all options visible, like with a dropdown. We can maybe consider making the dropdown searchable, but it feels okay to me to scan an alphabetical list. |
We have numbers next to all the other facets. If there's a UX issue, it's widespread (beyond this PR). You can open a new issue about the tooltip. There are several issues that can be closed at once, when tooltips are implemented. |
closes #96