chore: Lint JS and update fixture

open-contracting · Nov 7, 2024 · 3d8455a · 3d8455a
1 parent ac23184
commit 3d8455a
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/data_registry/templates/detail.html b/data_registry/templates/detail.html
@@ -60,9 +60,9 @@
 })
 
 document.querySelectorAll('a[download]').forEach(trackable => {
-    trackable.addEventListener('click', event => {
-        fathom.trackEvent(`download ${trackable.dataset.event}`)
-    })
+  trackable.addEventListener('click', event => {
+    fathom.trackEvent(`download ${trackable.dataset.event}`) // eslint-disable-line no-undef
+  })
 })
 </script>
 {% endblock %}

diff --git a/data_registry/templates/search.html b/data_registry/templates/search.html
@@ -16,7 +16,7 @@
   div.addEventListener('click', event => {
     // Stop "See details" from triggering a second event.
     event.preventDefault()
-    open(div.querySelector('.click').href, event.ctrlKey || event.metaKey || event.shiftKey ? '_blank' : '_self')
+    window.open(div.querySelector('.click').href, event.ctrlKey || event.metaKey || event.shiftKey ? '_blank' : '_self')
   })
 })
 

diff --git a/tests/data_registry/test_views.py b/tests/data_registry/test_views.py
@@ -95,7 +95,9 @@ def test_detail(self, get_files):
             response = Client().get(f"/en/publication/{self.collection1.id}")
 
             self.assertTemplateUsed("detail.html")
-            self.assertContains(response, f"""<a href="{url}" rel="nofollow" download>2022</a>""", html=True)
+            self.assertContains(
+                response, f"""<a href="{url}" rel="nofollow" data-event="jsonl.gz year" download>2022</a>""", html=True
+            )
 
     def test_collection_not_found(self):
         with self.assertNumQueries(1):