Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verificationMethod field #8

Merged
merged 3 commits into from
Feb 16, 2024
Merged

add verificationMethod field #8

merged 3 commits into from
Feb 16, 2024

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Jan 25, 2024

closes open-contracting/ocds-extensions#218
closes open-contracting/ocds-extensions#221

giving an overwrite error when compared to 1.2 which has had selectionCriteria added to it as a single string field rather than an object. This is partially under discussion in open-contracting/standard#1607

@odscjen
Copy link
Contributor Author

odscjen commented Feb 7, 2024

As discussed in open-contracting/ocds-extensions#221 (comment) an exemption needs to be added to the tests to prevent this failing.

This PR also updates the descriptions of tender.selectionCriteria and SelectionCriteria.description to match the descriptions in the same fields in OCDS 1.2

@jpmckinney
Copy link
Member

Need to merge open-contracting/standard#1674 first, then I'll add the exception.

@jpmckinney jpmckinney merged commit 69c3394 into master Feb 16, 2024
2 checks passed
@jpmckinney jpmckinney deleted the 218_verification_method branch February 16, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants