Skip to content

Commit

Permalink
Merge pull request #16 from open-contracting/extension-issues-40-add
Browse files Browse the repository at this point in the history
Add missing descriptions
  • Loading branch information
jpmckinney authored Jan 30, 2018
2 parents 77c380d + 42f3b81 commit d5a488f
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 5 deletions.
17 changes: 12 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,18 @@ In some cases, a fee may be levied for 'official copies' of procurement document

In this case, the fee should be modelled as a **submission** fee, as submission is only possible when this document access fee has been paid.

## To do

* participation / submission terminology
* finalize codelist

## Issues

Report issues for this extension in the [ocds-extensions repository](https://github.com/open-contracting/ocds-extensions/issues), putting the extension's name in the issue's title.

## Changelog

### v1.1.3

* Disallow `ParticipationFee.type` from having null in its array of strings
* Allow `ParticipationFee.description` to be null
* Add `ParticipationFee.id` field
* Add description to `ParticipationFee`
* Add title and description to `ParticipationFee.value`
* Add participationFeeType.csv codelist for `ParticipationFee.type`
* Add tests and tidy code
3 changes: 3 additions & 0 deletions release-schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"definitions": {
"ParticipationFee": {
"title": "Participation fee",
"description": "A fee applicable to bidders wishing to participate in the tender process. Fees may apply for access to bidding documents, for the submission of bids or there may be a win fee payable by the successful bidder.",
"type": "object",
"properties": {
"id": {
Expand Down Expand Up @@ -29,6 +30,8 @@
"openCodelist": false
},
"value": {
"title": "Value",
"description": "The monetary value of this fee.",
"$ref": "#/definitions/Value"
},
"description": {
Expand Down

0 comments on commit d5a488f

Please sign in to comment.