Skip to content

update container to immediateContainer #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

odscjen
Copy link
Contributor

@odscjen odscjen commented Dec 4, 2023

addresses part of open-contracting/standard#1343

@odscjen
Copy link
Contributor Author

odscjen commented Dec 4, 2023

@jpmckinney test_csv.py is looking specifically for "container.csv" at line 93

@pytest.mark.skipif(repo_name in ('european-union-support',), reason='not a codelist')
def test_codelist():
    """
    Ensures all codelists files are valid against codelist-schema.json.
    """
    exceptions = {
        'currency.csv': "'Description' is a required property",
        'language.csv': "'Description' is a required property",
        'mediaType.csv': "'Description' is a required property",
        # ocds_countryCode_extension
        'country.csv': "'Description' is a required property",
        # ocds_coveredBy_extension
        'coveredBy.csv': "'Description' is a required property",
        # ocds_medicine_extension
        'administrationRoute.csv': "'Description' is a required property",
        'container.csv': "None is not of type 'string'",
        'dosageForm.csv': "None is not of type 'string'",
    }

but this PR changes the name of this codelist to "immediateContainer.csv", I think that's what's causing this test to fail here.

@jpmckinney
Copy link
Member

Thanks! I've updated the test.

@jpmckinney jpmckinney merged commit 8916903 into master Dec 4, 2023
@jpmckinney jpmckinney deleted the 1343_medicine_units branch December 4, 2023 18:41
@jpmckinney
Copy link
Member

I added a changelog as a separate commit.

@odscjen odscjen removed the request for review from duncandewhurst December 5, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants