add lots.submissionTerms.electronicSubmissionPolicy #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the tests, but the issue is that submissionTerms doesn't have a definition in OCDS 1.2. You'll have to make a PR there first, then reference it here. |
|
Ah, yes I'd missed that the definition in 1.2 is in |
|
open-contracting/standard#1667 should fix the issue |
jpmckinney
reviewed
Dec 14, 2023
|
I fixed the comma as I also had to update the readme tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is failing I think because it's looking in core 1.1 for the field referenced by
#/definitions/submissionTermswhich has been added to 1.2-dev in open-contracting/standard#1654