Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

statistics.csv: Add codes for eForms #50

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Conversation

duncandewhurst
Copy link
Member

For 'tendersDisqualified', I omitted 'The number of' from the code's title, in keeping with the titles of other codes. If that sounds good, we should update the received-submission-type mapping table. I also retained the EU nomenclature of 'tenders' (rather than 'bids') in keeping with the existing 'tendersAbnormallyLow' code.

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To spare unrelated work in this PR, let's create an issue about deprecating 'tendersAbnormallyLow' in favor of 'abnormallyLowBids'.

Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, move disqualifiedBids under validBids.

README.md Outdated Show resolved Hide resolved
codelists/statistic.csv Outdated Show resolved Hide resolved
codelists/statistic.csv Outdated Show resolved Hide resolved
@jpmckinney
Copy link
Member

If that sounds good, we should update the received-submission-type mapping table.

Yes, sounds good

@duncandewhurst
Copy link
Member Author

If that sounds good, we should update the received-submission-type mapping table.

Yes, sounds good

Done in open-contracting/european-union-support@3866648

@duncandewhurst duncandewhurst requested a review from jpmckinney July 6, 2023 02:17
@jpmckinney jpmckinney merged commit 9668c14 into master Jul 6, 2023
@jpmckinney jpmckinney deleted the eforms-statistics branch July 6, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants